Skip to content

[preview] Pull Request to bump blead to 7.1.0 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: blead
Choose a base branch
from
Open

[preview] Pull Request to bump blead to 7.1.0 #181

wants to merge 5 commits into from

Conversation

@atoomic
Copy link
Owner

@atoomic atoomic commented Jul 31, 2020

This pull request bumps the Perl version to 7.1.0 with some incremental changes:

  • Devel-PPPort: Bump to upstream
  • version: use PERL_VERSION compare macros
  • hreads: use PERL_VERSION compare macros
  • Storable: use PERL_COMPARE macros
  • Update Perl version to 7.0.0
  • Update Perl version to 7.1.0

Note that in order to provide backward compatibility with XS distributions, PERL_REVISION, PERL_VERSION and PERL_SUBVERSION are frozen at 5.255.255 (view patchlevel.h)

We are now instead using some semantic versioning macros: PERL_VERSION_MAJOR, PERL_VERSION_MINOR, PERL_VERSION_PATCH

It's recommended to use the compare functions PERL_VERSION_EQ, PERL_VERSION_LT... instead of a direct access to these macros.

@toddr toddr requested review from toddr and xsawyerx July 31, 2020 20:10
@atoomic atoomic changed the title Setup of Pull Request to bump blead to 7.1.0 Dry Run Pull Request to bump blead to 7.1.0 Jul 31, 2020
@atoomic atoomic force-pushed the blead_to_710-PR branch 2 times, most recently from fa6b0cf to 77b11c8 Compare July 31, 2020 21:20
@toddr toddr force-pushed the blead_to_710-PR branch from dbcf846 to 23dfe56 Compare July 31, 2020 21:51
@toddr toddr force-pushed the blead_to_710-PR branch 2 times, most recently from cf6e07a to 89096dd Compare July 31, 2020 22:08
@atoomic atoomic force-pushed the blead_to_710-PR branch 2 times, most recently from 2d608be to d4575b2 Compare July 31, 2020 22:37
@atoomic atoomic requested a review from jkeenan July 31, 2020 22:47
@jkeenan
Copy link
Collaborator

jkeenan commented Jul 31, 2020

@atoomic, This is a p.r. from one branch in your repository to branch blead in the same repository. How does blead in this repository correspond to blead in https://github.com/Perl/perl5?

Thank you very much.
Jim Keenan

@jkeenan
Copy link
Collaborator

jkeenan commented Jul 31, 2020

@atoomic, @toddr : If this p.r. ultimately makes its way to Perl 5 blead, does it in any way affect how I and (hopefully) others will work in pursuit of the objectives on our roadmap, the next of which is Objective 2?

Thank you very much.
Jim Keenan

@atoomic
Copy link
Owner Author

atoomic commented Aug 1, 2020

@jkeenan blead in this repo points to the state blead was in Perl5 repo a few years ago

@atoomic
Copy link
Owner Author

atoomic commented Aug 1, 2020

@jkeenan this PR once merged will not impact the work you are doing for alpha.
All objectives you have defined are valid and should be pursue like you planned.

Leont
Leont reviewed Aug 1, 2020
View reviewed changes
Leont
Leont reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
Porting/config.sh
Comment on lines +46 to +48
api_revision='7'
api_subversion='0'
api_version='1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we're keeping these at their "old" names, rather than renaming them to api_version_{major,minor,patch} ?

Copy link
Contributor

@Leont Leont Aug 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backwards compatibility. This looks like exactly the thing Perl-Toolchain-Gang/ExtUtils-MakeMaker#358 needed. Generally speaking we can't remove %Config keys.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I would like to tackle these as a following task: patchlevel, subversion, api_*... macros are legacy
I think @ether is right, we want to remove them from core and let Devel-PPPort provide the backward compatibility layer. But this seems to me a follow up task and should not be part of this initial bump to 7.1.0.

leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
regen/feature.pl
for ('default', sort grep /\.\d[02468]/, keys %feature_bundle) {
$::bundle = ":$_";
$::feature = join ' ', @{$feature_bundle{$_}};
foreach my $bundle ('default', sort grep /\.\d*[02468]\z/a, keys %feature_bundle) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The \z in here looks wrong. It will skip the "5.9.5" three-component one.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right about the \z but removing it will have no effects
note that 5.9.5 bundle is currently not listed in feature.pm
view https://metacpan.org/pod/feature#FEATURE-BUNDLES
are you saying that this is a bug in blead and we should fix it?
Do you still think \z should be removed? I'm good with both options

leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
leonerd
leonerd reviewed Aug 1, 2020
View reviewed changes
@rjbs
Copy link
Contributor

rjbs commented Aug 1, 2020

Did read. Apart from a few things already mentioned, I had only a whitespace nit or two, so: 👍🏽

Tux
Tux reviewed Aug 1, 2020
View reviewed changes
@atoomic atoomic changed the title Dry Run Pull Request to bump blead to 7.1.0 [preview] Pull Request to bump blead to 7.1.0 Aug 1, 2020
@atoomic atoomic force-pushed the blead_to_710-PR branch 3 times, most recently from 28690e2 to 0431157 Compare August 1, 2020 20:53
@khwilliamson
Copy link
Contributor

khwilliamson commented Aug 2, 2020 via email

@atoomic atoomic force-pushed the blead_to_710-PR branch 3 times, most recently from e0f2e72 to fd89fe2 Compare August 3, 2020 02:26
@atoomic
Copy link
Owner Author

atoomic commented Aug 3, 2020

failures noticed on windows

Test Summary Report
-------------------
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/min_perl_version.t                  : 5)
  Failed tests:  3, 5, 7, 9, 12
  Non-zero exit status: 5
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/postamble.t                         1)
  Failed test:  4
  Non-zero exit status: 1
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/prereq.t                            : 8)
  Failed tests:  4-10, 13
  Non-zero exit status: 8
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/several_authors.t                    2)
  Failed tests:  3, 6
  Non-zero exit status: 2
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/vstrings.t                          : 14)
  Failed tests:  11, 13, 15, 29, 39, 41, 43, 45, 47, 49
                51, 53, 55, 57
  Non-zero exit status: 14
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/writemakefile_args.t                : 10)
  Failed tests:  4-5, 16, 18, 22, 26, 29, 32, 34, 36
  Non-zero exit status: 10
sv_last_five_version../ext/IPC-Open3/t/IPC-Open3.t                                   )
  TODO passed:   25
sv_last_five_version../lib/Config.t                                                  4)
  Failed tests:  7-8, 11-12
sv_last_five_versionFiles=2679, Tests=1088463, 1279 wallclock secs (81.58 usr +  7.97 sys = 89.55 CPU)
Result: FAIL

@atoomic atoomic force-pushed the blead_to_710-PR branch 4 times, most recently from 334c9a4 to 1114834 Compare August 3, 2020 15:10
atoomic and others added 4 commits August 4, 2020 14:31
@atoomic
version: use PERL_VERSION compare macros
b1d187d 
Use new core PERL_VERSION compare macros in vxs.inc
When bumping version which this change
we would need to make sure to use the last
version of ppport.h
@atoomic
Remove transitional helpers from handy.h
142676a
@atoomic
Update Perl version to 7.0.0
2d24c53 
To provide backward compatibility with XS code
PERL_REVISION, PERL_VERSION and PERL_SUBVERSION
are frozen at 5.255.255 - view patchlevel.h

This is introducing new Perl semantic versioning macros:
PERL_VERSION_MAJOR, PERL_VERSION_MINOR, PERL_VERSION_PATCH

It's recommended to use the compare functions
PERL_VERSION_EQ, PERL_VERSION_LT...
instead of a direct access to the `VERSION` macros.
@atoomic
Update Perl version to 7.1.0
b927ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xsawyerx xsawyerx Awaiting requested review from xsawyerx

@toddr toddr Awaiting requested review from toddr

@jkeenan jkeenan Awaiting requested review from jkeenan

3 more reviewers

@Tux Tux Tux left review comments

@Leont Leont Leont left review comments

@leonerd leonerd leonerd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@atoomic @jkeenan @rjbs @khwilliamson @Tux @Leont @toddr @leonerd